I have yet another blocker issue with Spirit Qi.
I have implemented error handling in a functor struct called error_handler. This is passed to the grammar constructor by reference (see the MiniC example for Qi).
I then have on_error<fail>
s defined in the grammar's constructor:
typedef boost::phoenix::function<error_handler<> > error_handler_function;
on_error<fail>(gr_instruction,
error_handler_function(err_handler)(L"Error: Expecting ", _4, _3));
// more on_error<fail>s...
However, my error_handler
has private members. It seems every time on_error
is invoked, the err_handler
object is copied, hence once the functor leaves, the local variables changed are destroyed.
I tried passing the handler by reference:
typedef boost::phoenix::function<error_handler<>& > error_handler_function; // <--- Note the ampersand!
on_error<fail>(gr_instruction,
error_handler_function(err_handler)(L"Error: Expecting ", _4, _3));
// more on_error<fail>s...
However, the problem remains: on_error()
works on copies of err_handler
, not a single instance!!
I have also tried variations of boost::phoenix::ref(err_handler)
with nothing but compile errors.
Surely, there must be an easy solution to passing the handler via reference?
I would appreciate any input. Thank you for your help.
I remembered having a late thought about this and wanted to check it:
Of course,
my_error_handler<> err_handler;
phx::function<my_error_handler<> > err_handler_(err_handler);
would work (but tries to copy the err_handler
instance, which is not what you want). Now,
phx::function<my_error_handler<> > err_handler_(phx::ref(err_handler));
isn't going to fly (as a my_error<>
cannot construct from a phx::ref(err_handler)
) so, logically, what you actually needed to do was just:
namespace P = boost::proto;
phx::function<const phx::actor<P::exprns_::basic_expr<
P::tagns_::tag::terminal,
P::argsns_::term<boost::reference_wrapper<my_error_handler<> > >,
0l>
> > err_handler_;
which... works exactly as the phx::bind
would, but with more syntactic sugar:
on_error<fail>(function, err_handler_(L"Error: Expecting ", _4, _3));
on_error<fail>(start, err_handler_(L"Error: Expecting ", _4, _3));
on_error<fail>(gr_instruction, err_handler_(L"Error: Expecting ", _4, _3));
Now, with some C++11 this can be written slightly less verbose:
my_error_handler<> err_handler;
phx::function<decltype(phx::ref(err_handler))> err_handler_;
See it working Live on Coliru with the code below:
#define BOOST_SPIRIT_USE_PHOENIX_V3
//#define BOOST_SPIRIT_DEBUG
#include <boost/spirit/include/qi.hpp>
#include <boost/spirit/include/phoenix.hpp>
namespace qi = boost::spirit::qi;
namespace phx = boost::phoenix;
namespace asmast
{
typedef std::string label;
}
template <typename=void> struct my_error_handler {
my_error_handler() = default;
my_error_handler(my_error_handler const&) = delete;
template<typename...> struct result { typedef void type; };
template<typename... T> void operator()(T&&...) const {
std::cerr << "my_error_handler invoked " << proof++ << "\n";
}
mutable int proof = 0;
};
template <typename It, typename Skipper = qi::blank_type>
struct parser : qi::grammar<It, Skipper>
{
parser() :
parser::base_type(start),
err_handler(),
err_handler_(phx::ref(err_handler))
{
using namespace qi;
start = lexeme["Func" >> !(alnum | '_')] > function;
function = gr_identifier
>> "{"
>> -(
gr_instruction
| gr_label
//| gr_vardecl
//| gr_paramdecl
) % eol
> "}";
gr_instruction_names.add("Mov", unused);
gr_instruction_names.add("Push", unused);
gr_instruction_names.add("Exit", unused);
gr_instruction = lexeme [ gr_instruction_names >> !(alnum|"_") ] > gr_operands;
gr_operands = -(gr_operand % ',');
gr_identifier = lexeme [ alpha >> *(alnum | '_') ];
gr_operand = gr_identifier | gr_string;
gr_string = lexeme [ '"' >> *("\"\"" | ~char_("\"")) >> '"' ];
gr_newline = +( char_('\r')
|char_('\n')
);
gr_label = gr_identifier >> ':' > gr_newline;
#if 0
on_error<fail>(function, phx::bind(phx::ref(err_handler), L"Error: Expecting ", _4, _3));
on_error<fail>(start, phx::bind(phx::ref(err_handler), L"Error: Expecting ", _4, _3));
on_error<fail>(gr_instruction, phx::bind(phx::ref(err_handler), L"Error: Expecting ", _4, _3));
#else
on_error<fail>(function, err_handler_(L"Error: Expecting ", _4, _3));
on_error<fail>(start, err_handler_(L"Error: Expecting ", _4, _3));
on_error<fail>(gr_instruction, err_handler_(L"Error: Expecting ", _4, _3));
#endif
// more on_error<fail>s...
BOOST_SPIRIT_DEBUG_NODES((start)(function)(gr_instruction)(gr_operands)(gr_identifier)(gr_operand)(gr_string));
}
my_error_handler<> err_handler;
phx::function<decltype(phx::ref(err_handler))> err_handler_;
private:
qi::symbols<char, qi::unused_type> gr_instruction_names;
qi::rule<It, Skipper> start, function, gr_instruction, gr_operands, gr_operand, gr_string;
qi::rule<It, qi::unused_type()> gr_newline;
qi::rule<It, asmast::label(), Skipper> gr_label, gr_identifier;
};
int main()
{
typedef boost::spirit::istream_iterator It;
std::cin.unsetf(std::ios::skipws);
It f(std::cin), l;
parser<It, qi::blank_type> p;
try
{
bool ok = qi::phrase_parse(f,l,p,qi::blank);
if (ok) std::cout << "parse success\n";
else std::cerr << "parse failed: '" << std::string(f,l) << "'\n";
if (f!=l) std::cerr << "trailing unparsed: '" << std::string(f,l) << "'\n";
std::cout << "The 'proof' in the err_handler instance is: " << p.err_handler.proof << "\n";
return ok;
} catch(const qi::expectation_failure<It>& e)
{
std::string frag(e.first, e.last);
std::cerr << e.what() << "'" << frag << "'\n";
}
return false;
}
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With