Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Bitmap.SetPixel acts slower in f# than in c#

Tags:

c#

f#

The f# code goes literally 500 times slower than the c# code. What am I doing wrong? I tried to make the code basically the same for both languages. It doesn't make sense that SetPixel would be that much slower in f#.

F#:

module Imaging
open System.Drawing;
#light
type Image (width : int, height : int) = class
  member z.Pixels = Array2D.create width height Color.White

  member z.Width with get() = z.Pixels.GetLength 0

  member z.Height with get() = z.Pixels.GetLength 1

  member z.Save (filename:string) =     
    let bitmap = new Bitmap(z.Width, z.Height)
    let xmax = bitmap.Width-1
    let ymax = bitmap.Height-1
    let mutable bob = 0;
    for x in 0..xmax do
      for y in 0..ymax do
        bitmap.SetPixel(x,y,z.Pixels.[x,y])
    bitmap.Save(filename)

  new() = Image(1280, 720)
end
let bob = new Image(500,500)
bob.Save @"C:\Users\White\Desktop\TestImage2.bmp"

C#:

using System.Drawing;

namespace TestProject
{
public class Image
{

    public Color[,] Pixels;
    public int Width
    {
        get
        {
            return Pixels.GetLength(0);
        }
    }
    public int Height
    {
        get
        {
            return Pixels.GetLength(1);
        }
    }

    public Image(int width, int height)
    {
        Pixels = new Color[width, height];
        for (int x = 0; x < Width; x++)
        {
            for (int y = 0; y < Height; y++)
            {
                Pixels[x, y] = Color.White;
            }
        }
    }

    public void Save(string filename)
    {
        Bitmap bitmap = new Bitmap(Width, Height);
        for (int x = 0; x < bitmap.Width; x++)
        {
            for (int y = 0; y < bitmap.Height; y++)
            {
                bitmap.SetPixel(x, y, Pixels[x, y]);
            }
        }
        bitmap.Save(filename);
    }
}
class Program
{
    static void Main(string[] args)
    {
        Image i = new Image(500, 500);
        i.Save(@"C:\Users\White\Desktop\TestImage2.bmp");
    }
}
}
like image 703
phil Avatar asked Aug 20 '13 17:08

phil


1 Answers

Your definition of the Pixels property in F# is wrong: each time its value is accessed (e.g. in the inner loop of Save), the definition will be reevaluated. You should use this form instead:

member val Pixels = Array2D.create width height Color.White

This will evaluate the right-hand side exactly once, when the constructor is called, and then cache the value.

like image 183
kvb Avatar answered Nov 11 '22 23:11

kvb