Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

best practise/way for master detail / multi table Insert in Entity Framework

My table structure is this

Orders
------ 
Id int identity
OrderDate smalldatetime
OrderStatusid tinyint

Products
--------
Id int identity
Name varchar(50)

OrderDetails
------------
Id int identity
OrderId int (fkey)
ProductId int (fkey)
Amount decimal
Rate decimal

I am trying to an insert operation using Entity Framework using the code below
Is this the best way to do the insert?
I am not happy with the way I am getting the full product item from the context object, instead of being able to just assign a simple productId value

using (MyContextEntities ctx = new MyContextEntities())
{
    Orders newOrder = new Orders()
    {
    Name = "Gayle Wynand",
    OrderDate = DateTime.Now,
    IsComplete = true,
    Comments = "test",
    OrderStatusId = 2,
    IsActive = true
    };
    OrderDetails ode = new OrderDetails();
    ode.Products = ctx.Products.First(p => p.Id == 2); // any other way?
    ode.Quantity = 2;
    ode.Rate = 5.2;
    newOrder.OrderDetails.Add(ode);

    OrderDetails ode2 = new OrderDetails();
    ode2.Products = ctx.Products.First(p => p.Id == 3); // any other way?
    ode2.Quantity = 3;
    ode2.Rate =6.5;
    newOrder.OrderDetails.Add(ode2);


    ctx.AddToOrders(newOrder);
    ctx.SaveChanges();
}

Is this the correct way to do the master detail insert or is there a better/another way.

like image 855
Binoj Antony Avatar asked Jul 21 '09 12:07

Binoj Antony


2 Answers

What you are doing now will work just fine.

If you would like to avoid doing a database query when assigning ode.Products, then you could use the following alternative:

// substitute your actual qualified entity set name
ode.ProductsReference.EntityKey = 
    new EntityKey("MyEntities.ProductsEntitySetName", "Id", 2);

This is faster, but less readable. Also, the Products property will be null until you Load it. But for an insert, this is often OK.

like image 82
Craig Stuntz Avatar answered Oct 27 '22 00:10

Craig Stuntz


Another approach would be to use Stub Objects rather than EntityKeys i.e.

var product = new Product {ID = 2};
ctx.AttachTo("Products", product);
ode.Product = product;

etc. As an added bonus this code will work with POCO objects too in the future.

See this blog post for more information on that technique.

like image 42
Alex James Avatar answered Oct 26 '22 23:10

Alex James