Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

ASP.Net Core Identity JWT Role-Base Authentication is Forbidden

Good day.

The API is for a Quote sharing web-app.

I have setup role-based JWT authentication where I have "Member" and "Admin" roles with users of those roles correctly registered and able to retrieve tokens.

So far, methods (or classes) with only

[Authorize]

can be correctly accessed provided a registered token.

Now once I added roles, access to methods or classes that require a certain role

[Authorize(Role="Admin")]

is Forbidden (403), even though I do pass a correct token with the Authorization header.

Please note: I have verified that users are correctly created (dbo.AspNetUsers), roles are correctly created (dbo.AspNetRoles containing "Admin" and "Member" roles) and user-roles are correctly mapped (dbo.AspNetUserRoles).

This is the Startup class which contains a method CreateRoles() that's called by Configure():

public class Startup
{
    public Startup(IConfiguration configuration)
    {
        Configuration = configuration;
    }

    public IConfiguration Configuration { get; }


    public void ConfigureServices(IServiceCollection services)
    {
        services.AddDbContext<QuotContext>(options =>
            options.UseSqlServer(Configuration.GetConnectionString("DefaultConnection")));

        services.AddIdentity<Member, IdentityRole>()
            .AddEntityFrameworkStores<QuotContext>()
            .AddDefaultTokenProviders();

        services.Configure<IdentityOptions>(options =>
        {
            // Password settings
            options.Password.RequireDigit = false;
            options.Password.RequiredLength = 4;
            options.Password.RequireNonAlphanumeric = false;
            options.Password.RequireUppercase = false;
            options.Password.RequireLowercase = false;
            options.Password.RequiredUniqueChars = 2;

            // Lockout settings
            options.Lockout.DefaultLockoutTimeSpan = TimeSpan.FromMinutes(30);
            options.Lockout.MaxFailedAccessAttempts = 10;
            options.Lockout.AllowedForNewUsers = true;

            // User settings
            options.User.RequireUniqueEmail = true;
        });


        services.AddLogging(builder =>
        {
            builder.AddConfiguration(Configuration.GetSection("Logging"))
                .AddConsole()
                .AddDebug();
        });

        JwtSecurityTokenHandler.DefaultInboundClaimTypeMap.Clear(); // => remove default claims

        services
            .AddAuthentication(options =>
            {
                options.DefaultAuthenticateScheme = JwtBearerDefaults.AuthenticationScheme;
                options.DefaultScheme = JwtBearerDefaults.AuthenticationScheme;
                options.DefaultChallengeScheme = JwtBearerDefaults.AuthenticationScheme;

            })
            .AddJwtBearer(cfg =>
            {
                cfg.RequireHttpsMetadata = false;
                cfg.SaveToken = true;
                cfg.TokenValidationParameters = new TokenValidationParameters
                {
                    ValidIssuer = Configuration["JwtIssuer"],
                    ValidAudience = Configuration["JwtIssuer"],
                    IssuerSigningKey = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(Configuration["JwtKey"])),
                    ClockSkew = TimeSpan.Zero // remove delay of token when expire
                };
            });

        services.AddMvc();
    }


    public void Configure(IApplicationBuilder app, IHostingEnvironment env, IServiceProvider serviceProvider, QuotContext dbContext)
    {
        if (env.IsDevelopment())
        {
            app.UseDeveloperExceptionPage();
            app.UseBrowserLink();
            app.UseDatabaseErrorPage();
        }

        app.UseAuthentication();

        app.UseMvc();

        dbContext.Database.EnsureCreated();

        CreateRoles(serviceProvider).Wait();
    }

    private async Task CreateRoles(IServiceProvider serviceProvider)
    {
        //initializing custom roles 
        var RoleManager = serviceProvider.GetRequiredService<RoleManager<IdentityRole>>();
        var UserManager = serviceProvider.GetRequiredService<UserManager<Member>>();
        string[] roleNames = { "Admin", "Member" };
        IdentityResult roleResult;

        foreach (var roleName in roleNames)
        {
            var roleExist = await RoleManager.RoleExistsAsync(roleName);
            if (!roleExist)
                roleResult = await RoleManager.CreateAsync(new IdentityRole(roleName));
        }

        var poweruser = new Member
        {
            UserName = Configuration["AppSettings:AdminEmail"],
            Email = Configuration["AppSettings:AdminEmail"],
        };

        string password = Configuration["AppSettings:AdminPassword"];
        var user = await UserManager.FindByEmailAsync(Configuration["AppSettings:AdminEmail"]);

        if (user == null)
        {
            var createPowerUser = await UserManager.CreateAsync(poweruser, password);
            if (createPowerUser.Succeeded)
                await UserManager.AddToRoleAsync(poweruser, "Admin");
        }
    }
}

This is the MembersController class containing Register() and Login() methods:

[Authorize]
public class MembersController : Controller
{
    private readonly QuotContext _context;
    private readonly UserManager<Member> _userManager;
    private readonly SignInManager<Member> _signInManager;
    private readonly ILogger<MembersController> _logger;
    private readonly IConfiguration _configuration;

    public MembersController(QuotContext context, UserManager<Member> userManager,
        SignInManager<Member> signInManager, ILogger<MembersController> logger,
        IConfiguration configuration)
    {
        _context = context;
        _userManager = userManager;
        _signInManager = signInManager;
        _logger = logger;
        _configuration = configuration;
    }

    [HttpPost("register")]
    [AllowAnonymous]
    public async Task<IActionResult> Register([FromBody] RegisterModel model)
    {
        if (ModelState.IsValid)
        {
            var newMember = new Member
            {
                UserName = model.Email,
                Email = model.Email,
                PostCount = 0,
                Reputation = 10,
                ProfilePicture = "default.png"
            };

            var result = await _userManager.CreateAsync(newMember, model.Password);

            if (result.Succeeded)
            {
                _logger.LogInformation(1, "User registered.");
                await _signInManager.SignInAsync(newMember, false);

                return Ok(new { token = BuildToken(model.Email, newMember) });
            }

            _logger.LogInformation(1, "Registeration failed.");
            return BadRequest();
        }

        return BadRequest();
    }

    [HttpPost("login")]
    [AllowAnonymous]
    public async Task<IActionResult> Login([FromBody] LoginModel model)
    {
        if (ModelState.IsValid)
        {
            var result = await _signInManager.PasswordSignInAsync(model.Email,
                model.Password, model.RememberMe, lockoutOnFailure: false);

            if (result.Succeeded)
            {
                _logger.LogInformation(1, "User logged in." + _configuration["AppSettings:AdminPassword"]);
                var member = _userManager.Users.SingleOrDefault(r => r.Email == model.Email);

                return Ok(new { token = BuildToken(model.Email, member) });
            }

            _logger.LogInformation(1, "Login failed.");
            return BadRequest();
        }

        return BadRequest(ModelState);
    }

    private string BuildToken(string email, Member member)
    {
        var claims = new List<Claim>
        {
            new Claim(JwtRegisteredClaimNames.Sub, email),
            new Claim(JwtRegisteredClaimNames.Jti, Guid.NewGuid().ToString()),
            new Claim(ClaimTypes.NameIdentifier, member.Id)
        };

        var key = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(_configuration["JwtKey"]));
        var creds = new SigningCredentials(key, SecurityAlgorithms.HmacSha256);
        var expires = DateTime.Now.AddDays(Convert.ToDouble(_configuration["JwtExpireDays"]));

        var token = new JwtSecurityToken(
            _configuration["JwtIssuer"],
            _configuration["JwtIssuer"],
            claims,
            expires: expires,
            signingCredentials: creds
        );

        return new JwtSecurityTokenHandler().WriteToken(token);
    }

}

Here's the example of 2 methods: the first requiring simple authentication which is successfully accessed provided a user token, and the second which is forbidden even given an admin token:

public class AuthorsController : Controller
{
    private readonly QuotContext _context;

    public AuthorsController(QuotContext context)
    {
        _context = context;
    }

    [HttpGet]
    [Authorize]
    public IEnumerable<Author> GetAuthors()
    {
        return _context.Authors;
    }

    [HttpPost]
    [Authorize(Roles = "Admin")]
    public async Task<IActionResult> PostAuthor([FromBody] Author author)
    {
        if (!ModelState.IsValid)
        {
            return BadRequest(ModelState);
        }

        _context.Authors.Add(author);
        await _context.SaveChangesAsync();

        return StatusCode(201);
    }
}

Thank you for your help. A github repo containing the full project: https://github.com/theStrayPointer/QuotAPI

like image 887
Ash Avatar asked Jan 14 '18 23:01

Ash


1 Answers

I got the same problem. I've just find a way. In fact, a JWT token embeds the roles. So you have to add role claims in your token when you generate it.

var roles = await _userManager.GetRolesAsync(user);
var claims = new[]
{
    new Claim(JwtRegisteredClaimNames.Sub, user.Id.ToString()),
    new Claim(JwtRegisteredClaimNames.Jti, Guid.NewGuid().ToString()),
    new Claim(JwtRegisteredClaimNames.Iat, ToUnixEpochDate(dateTime).ToString(), ClaimValueTypes.Integer64)
};

ClaimsIdentity claimsIdentity = new ClaimsIdentity(claims, "Token");
// Adding roles code
// Roles property is string collection but you can modify Select code if it it's not
claimsIdentity.AddClaims(roles.Select(role => new Claim(ClaimTypes.Role, role)));

var token = new JwtSecurityToken
(
    _configuration["Auth:Token:Issuer"],
    _configuration["Auth:Token:Audience"],
    claimsIdentity.Claims,
    expires: dateTime,
    notBefore: DateTime.UtcNow,
    signingCredentials: new SigningCredentials(new SymmetricSecurityKey(Encoding.UTF8.GetBytes(_configuration["Auth:Token:Key"])), SecurityAlgorithms.HmacSha256)
);

Found an explanation here and here.

like image 80
Pier-Lionel Sgard Avatar answered Oct 17 '22 19:10

Pier-Lionel Sgard