Are multiple calls to string.Replace() less efficient than a single call to a Regex method in .NET?

Question

I want to replace about 8 characters in a string.

Would it be more efficient to use a Regex method or just use multiple calls to string.Replace()

I'm replacing about 7 characters that may appear, all to be underscores instead. The characters could appear anywhere in the string, and not in a particular order etc.

Answer 1

Don't use the Regex class unless you actually need to match a regular expression. It's much more efficient to let the String type do straight text or character matching if that's all your doing than to create a Regex.

The Regex class is much more powerful than simple character or string matching. This power does not come for free. Using a full regex to match a character / string is overkill. It's the equivalent of using a high power explosive to remove a single ant from your lawn when your shoe would do just fine.

Answer 2

You don't need to make multiple calls to string.Replace() - it replaces all occurences in a single pass. See the MSDN documentation. You only need to make multiple calls if you are replacing different input sequences within the string (which may be what you're implying in your question).

In that case, I would use string.Split and string.Join for this:

var replaced = string.Join( "_", input.Split( new[]{'x','y','z'} ) );

This will split the string at every location where one of the characters 'x', 'y', or 'z' occurs (replace with your set) and will rejoin the fragments using the '_' character -- effectively replacing the originals. This approach is NOT necessarily more efficient than multiple calls to string.Replace - that would depend on the length of the input string, the number of occurences of the characters to replace, and so on. You would need to do profiling with real-world data to determine what is faster. What this approach does do, however, is make the code more concise.

As far as performance is concerned - I would go with the simplest and most readable solution first, and if testing demonstrates a problem - then I would profile and decide what alternative solutions to pursue (if any). Unless there are strong reasons to do otherwise, my personal priorities when writing code are:

1. Make it correct.
2. Make it clear.
3. Make it concise.
4. Make it fast.
5. .. In that order.

Answer 3

At the same time, depending on how long these strings may be and how many characters may need to be replaced, you should use a StringBuilder object rather than a string.

Strings are immutable, so in each replacement you'd be creating a new string with the underscore. The StringBuilder class is more efficient for multiple changes to a string object.