Are Dictionary Keys and Values enumerated in the same order?

Question

I have scenario where I have to send the Dictionary that was sent as an input as comma seperated strings to a stored procedure.

I am wondering whether if I do it like below will there be any possible case that it may send the incorrect value for a given key in the dictionary?

static void Main(string[] args)
{
    Dictionary<int, string> test = new Dictionary<int, string>();
    test.Add(1, "1");
    test.Add(3, "3");
    test.Add(4, "4");
    test.Add(5, "5");
    test.Add(2, "2");
    JoinTest(test);
}

private static void JoinTest(Dictionary<int, string> test)
{
    var keys = string.Join(",", test.Keys);
    var values = string.Join(",", test.Values);
}

Answer 1

Read the documentation. It clearly states:

The order of the keys in the Dictionary.KeyCollection is unspecified, but it is the same order as the associated values in the Dictionary.ValueCollection returned by the Values property.

and

The order of the values in the Dictionary.ValueCollection is unspecified, but it is the same order as the associated keys in the Dictionary.KeyCollection returned by the Keys property.

So yes, keys and values match, but as commenters pointed out, you may have other problems here already.

Answer 2

Joey's answer is correct, although the order is only guaranteed if no modifications has been made to the dictionary, as pointed out in the comments. If you want to make sure that the order is the same you can do like this:

var dictionary = new Dictionary<int, string>();
var listOfKeyValuePairs = dictionary.ToList();
var keys = listOfKeyValuePairs.Select(kvp => kvp.Key);
var values = listOfKeyValuePairs.Select(kvp => kvp.Value);