Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

App crashes when pressing link on UITextView

I'm facing a weird bug in my iOS app, and it only happens in device. In my app I've a home page, from there if user presses a button I'll show a FormSheet (About Us page).

let storyBoard = UIStoryboard(name: "Utility", bundle: nil);
let aboutUsVC  = storyBoard.instantiateViewControllerWithIdentifier("AboutUs") as! AboutUsViewController;
aboutUsVC.modalPresentationStyle = .FormSheet;
aboutUsVC.preferredContentSize   = CGSize(width: 500,height: 400);
self.presentViewController(aboutUsVC, animated: true, completion: nil);

I've placed a UITextView inside that about us page and added a link as it's content: Link in Text View

Issue 1

When I long press on that link I'm getting a warning message on my console:

<_UIRotatingAlertController: 0x13e107200> on which is already presenting

Issue 2

After the long press if I click on the link again, the app crashes with following message:

2016-03-16 18:11:37.022 MyApp[938:400786] *** Assertion failure in -[UITextView startInteractionWithLinkAtPoint:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKit/UIKit-3512.29.5/UITextView_LinkInteraction.m:377

2016-03-16 18:11:37.023 MyApp[938:400786] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '' *** First throw call stack: (0x184220f48 0x198e47f80 0x184220e18 0x185114a1c 0x18a12de50 0x189d38be4 0x189d2f330 0x189958b5c 0x1897e685c 0x189d3070c 0x1897a58b8 0x1897a263c 0x1841d7bd0 0x1841d5974 0x1841d5da4 0x184104ca0 0x18f184088 0x18981cffc 0x100188368 0x19968a8b8) libc++abi.dylib: terminating with uncaught exception of type NSException

I think the UIKit is causing that crash. How can I fix this crash ?

More Info:

  1. Base SDK : 9.2
  2. Deployment Target : 8.1
  3. Xcode Version : 7.2.1
  4. iOS Device OS Version : 9.1
like image 932
Midhun MP Avatar asked Mar 16 '16 13:03

Midhun MP


2 Answers

As mentioned in this Apple Forum post, I implemented the following UITextViewDelegate and it solved my issue

func textView(textView: UITextView, shouldInteractWithURL URL: NSURL, inRange characterRange: NSRange) -> Bool
{
    UIApplication.sharedApplication().openURL(URL)
    return false  
}  

@Louis Tur: Thanks for the link

Swift 5.2

 @available(iOS 10.0, *)
func textView(_ textView: UITextView, shouldInteractWith url: URL, in characterRange: NSRange, interaction: UITextItemInteraction) -> Bool 
{
    UIApplication.shared.openURL(url)
    return false  
}

@available(iOS, deprecated: 10.0)
func textView(_ textView: UITextView, shouldInteractWith url: URL, in characterRange: NSRange) -> Bool 
{
   UIApplication.shared.openURL(url)
   return false  
}
like image 63
Midhun MP Avatar answered Sep 19 '22 11:09

Midhun MP


My fix for the crash was to implement both the deprecated and its replacement delegate methods.

/// Gets called if iOS version is >= 10.
@available(iOS 10.0, *)
func textView(_ textView: UITextView, shouldInteractWith URL: URL, in characterRange: NSRange, interaction: UITextItemInteraction) -> Bool {
    return textViewShouldInteractWithURL(URL: URL)
}

/// deprecated delegate method. Gets called if iOS version is < 10.
func textView(_ textView: UITextView, shouldInteractWith URL: URL, in characterRange: NSRange) -> Bool {
    return textViewShouldInteractWithURL(URL: URL)
}

func textViewShouldInteractWithURL(URL: URL) -> Bool {
    // common logic here
}
like image 29
Victor Bogdan Avatar answered Sep 21 '22 11:09

Victor Bogdan