Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

animated scrolling script prevents local anchor positions to be accessed from external links

I have a onepager site where I use scrollmagic plus all its necessary plugins/libraries (and jQuery) for different effects where animation, pinning, fading processes etc. are triggered by scroll positions.

I also use it for animated scrolling to the anchor points on the page (from the menu and from other local links) - see the according part of the script below.

The problem is that this script suppresses the default behaviour of "jumping" directly to an anchorpoint when a local link is clicked, and apparently also when the page is accessed from outside via a direct link or bookmark with an anchor appended to the URL (like http://www.example.com/index.php#part3). Altough this behaviour is desired when clicking a local link, it obviously prevents the browser from displaying the anchor position when an anchor is linked from somewhere else.

Is there any way to make the browser directly display that anchor position when a link like in the above example is clicked?

var sm_controller_1 = new ScrollMagic.Controller();

sm_controller_1.scrollTo(function(anchor_id) {
        TweenMax.to(window, 2.0, {
                scrollTo: {
                        y: anchor_id
                        autoKill: true
                },
                ease: Cubic.easeInOut
        });
});
jQuery(document).on("click", "a[href^=#]", function(e) {
        var id = jQuery(this).attr('href');
        if(jQuery(id).length > 0) {
                e.preventDefault();
                sm_controller_1.scrollTo(id);
                if (window.history && window.history.pushState) {
                        history.pushState("", document.title, id);
                }
        }
});

(It doesn't make sense to create a fiddle/codepen since the problem lies in calling the original URL from an external source).

like image 591
Johannes Avatar asked Mar 21 '16 17:03

Johannes


2 Answers

Well assuming scroll magic doesnt have extra functionality that is not posted here that would get in the way of my answer you could try this:

Add a data-attribute to your links which you want to use default behavior:

<a href="example.com/index.php#part3.php" data-default="true">

Check if that data attribute exists and if it does return true in your click handler to continue with the default behavior:

var sm_controller_1 = new ScrollMagic.Controller();

sm_controller_1.scrollTo(function(anchor_id) {
        TweenMax.to(window, 2.0, {
                scrollTo: {
                        y: anchor_id
                        autoKill: true
                },
                ease: Cubic.easeInOut
        });
});
jQuery(document).on("click", "a[href^=#]", function(e) {
        if(e.currentTarget.dataset.default){
            return true;
        }
        var id = jQuery(this).attr('href');
        if(jQuery(id).length > 0) {
                e.preventDefault();
                sm_controller_1.scrollTo(id);
                if (window.history && window.history.pushState) {
                        history.pushState("", document.title, id);
                }
        }
});
like image 56
pizzarob Avatar answered Oct 12 '22 23:10

pizzarob


You can try and use this code:

jQuery(function ($) {
    $(document).ready(function() {// if needed, use window.onload which fires after this event
        if(window.location.hash) {
            var hash = window.location.hash;
            $( 'a[href=' + hash + ']' ).click();
        }
    });
});

It will wait till the DOM (or the page) is loaded and then simulate the user click on the nav item.

After I've read your question one more time, I am not sure anymore if you want your page loaded on the position of the element which is listed in the anchor or the scroll wasn't working when coming from an external source?

If the scroll was working but you wanted to display the page at the right place, like a jump, then I propose 2 solutions:

a) use the CSS opacity:0; on the body and after the scroll is finished, set it back to opacity:1; b) try to jump on the proper place on the page before you load ScrollMagic

like image 26
dev_masta Avatar answered Oct 13 '22 01:10

dev_masta