Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Android BroadcastReceiver onReceive() called twice on android 5.1.1 even after one register

I Could not figure out what is wrong with below code. I also checked about registering receiver twice. But that's also not the case. or may be I am missing something. Could any please help. I really need it. :(

import android.app.Service;
import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
import android.content.IntentFilter;
import android.os.Bundle;
import android.os.IBinder;
import android.telephony.TelephonyManager;
import android.util.Log;
import android.widget.Toast;

/**
 * 
 * @author Bharat
 *
 */
public class CallNotifierService extends Service 
{
    private static final String ACTION_IN = "android.intent.action.PHONE_STATE";
    private static final String ACTION_OUT = "android.intent.action.NEW_OUTGOING_CALL";
    private CallBr br_call;

    @Override
    public IBinder onBind(Intent arg0) 
    {
        return null;
    }

    @Override
    public void onDestroy() 
    {
        Log.d("service", "destroy");
        this.unregisterReceiver(this.br_call);
        super.onDestroy();
    }

    @Override
    public int onStartCommand(Intent intent, int flags, int startId)
    {
        final IntentFilter filter = new IntentFilter();
        filter.addAction(ACTION_OUT);
        filter.addAction(ACTION_IN);
        this.br_call = new CallBr();
        this.registerReceiver(this.br_call, filter);
        return START_NOT_STICKY;
    }

    public class CallBr extends BroadcastReceiver 
    {
        Bundle bundle;
        String state;
        String inCall, outCall;
        public boolean wasRinging = false;
        public boolean answered = false;
        public boolean outgoing = false;

        @Override
        public void onReceive(Context context, Intent intent) 
        {
            if (intent.getAction().equals(ACTION_IN)) 
            {
                if ((bundle = intent.getExtras()) != null) 
                {
                    state = bundle.getString(TelephonyManager.EXTRA_STATE);

                    if (state.equals(TelephonyManager.EXTRA_STATE_RINGING)) 
                    {
                        inCall = bundle.getString(TelephonyManager.EXTRA_INCOMING_NUMBER);
                        wasRinging = true;
                        Toast.makeText(context, "Incoming Call : " + inCall, Toast.LENGTH_LONG).show();
                    } 
                    else if (state.equals(TelephonyManager.EXTRA_STATE_OFFHOOK)) 
                    {
                        if (wasRinging == true) 
                        {
                            answered = true;
                            Toast.makeText(context, "Answered", Toast.LENGTH_LONG).show();
                        }
                    } 
                    else if (state.equals(TelephonyManager.EXTRA_STATE_IDLE)) 
                    {
                        wasRinging = false;
                        Toast.makeText(context, "Disconnected", Toast.LENGTH_LONG).show();
                    }
                }
            } 
            else if (intent.getAction().equals(ACTION_OUT)) 
            {
                if ((bundle = intent.getExtras()) != null) 
                {
                    outCall = intent.getStringExtra(Intent.EXTRA_PHONE_NUMBER);
                    Toast.makeText(context, "Outgoing Call : " + outCall, Toast.LENGTH_LONG).show();
                    outgoing = true;
                }
            }
        }
    }
}

Below is the activity I am calling it from

public class MyActivity extends Activity 
{

@Override
protected void onCreate(Bundle savedInstanceState) 
{
    super.onCreate(savedInstanceState);
    setContentView(R.layout.roaming);

    Intent intent = new Intent(this, CallNotifierService.class);
    startService(intent);
}
.
.
.
}

Manifest

<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="ind.cosmos.main"
    android:versionCode="1"
    android:versionName="1.0" >

    <uses-permission android:name="android.permission.READ_CALL_LOG" />
    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
    <uses-permission android:name="android.permission.READ_PHONE_STATE" />
    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
    <uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
    <uses-permission android:name="android.permission.PROCESS_OUTGOING_CALLS" />

    <uses-sdk
        android:minSdkVersion="22"
        android:targetSdkVersion="22" />

    <application
        android:allowBackup="true"
        android:icon="@drawable/ic_launcher"
        android:label="@string/app_name" >

        <!-- android:theme="@style/AppTheme"> -->
        <activity
            android:name="ind.cosmos.main.MainActivity"
            android:label="@string/app_name" >
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />

                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>
        </activity>
        <service android:name="ind.cosmos.callRecord.CallNotifierService" />
    </application>

like image 684
Bharat Avatar asked Feb 18 '16 10:02

Bharat


2 Answers

As Bharat said it's better so handle it in code. Below is a trick to do so, found here, thanks to Michael Marvick who has given detail description as well.

     public class PhoneStateBroadcastReceiver extends BroadcastReceiver {

        public static final String TAG = "PHONE STATE";
        private static String mLastState;

        @Override
        public void onReceive(Context context, Intent intent) {
            String state = intent.getStringExtra(TelephonyManager.EXTRA_STATE);

            if (!state.equals(mLastState)) {
                mLastState = state;
                Log.e(TAG, state);
            }
        }
    }
like image 60
Chitrang Avatar answered Sep 22 '22 06:09

Chitrang


Actually .. there is nothing wrong with the code. its System who triggers this. some time its 2 times.. other times it touches 4 times.

So the best we can do it handle it in the code itself.

like image 27
Bharat Avatar answered Sep 22 '22 06:09

Bharat