Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Android 4.0 ICS turning HttpURLConnection GET requests into POST requests

My Galaxy Nexus arrived today, and one of the first things I did was to load my app onto it so I could demonstrate it to my friends. Part of its functionality involves importing RSS Feeds from Google Reader. However, upon trying this, I was getting 405 Method Not Allowed errors.

This problem is Ice Cream Sandwich-specific. The code I've attached works fine on Gingerbread and Honeycomb. I've traced the error down to the moment the connection is made, when the GET request magically turns into a POST request.

/**
 * Get the authentication token from Google
 * @param auth The Auth Key generated in getAuth()
 * @return The authentication token
 */
private String getToken(String auth) {
    final String tokenAddress = "https://www.google.com/reader/api/0/token";
    String response = "";
    URL tokenUrl;

    try {
        tokenUrl = new URL(tokenAddress);
        HttpURLConnection connection = (HttpURLConnection) tokenUrl.openConnection();

        connection.setRequestMethod("GET");
        connection.addRequestProperty("Authorization", "GoogleLogin auth=" + auth);
        connection.setRequestProperty("Content-Type","application/x-www-form-urlendcoded");
        connection.setUseCaches(false);
        connection.setDoOutput(true);
        Log.d(TAG, "Initial method: " + connection.getRequestMethod()); // Still GET at this point

        try {
            connection.connect();
            Log.d(TAG, "Connected. Method is: " + connection.getRequestMethod());  // Has now turned into POST, causing the 405 error
            InputStream in = new BufferedInputStream(connection.getInputStream());
            response = convertStreamToString(in);
            connection.disconnect();
            return response;

        }
        catch (Exception e) {
            Log.d(TAG, "Something bad happened, response code was " + connection.getResponseCode()); // Error 405
            Log.d(TAG, "Method was " + connection.getRequestMethod()); // POST again
            Log.d(TAG, "Auth string was " + auth);
            e.printStackTrace();
            connection.disconnect();
            return null;
        }
    }
    catch(Exception e) {
        // Stuff
        Log.d(TAG, "Something bad happened.");
        e.printStackTrace();
        return null;
    }
}

Is there anything that could be causing this problem? Could this function be better coded to avoid this problem?

Many thanks in advance.

like image 617
Michael Dodd Avatar asked Nov 18 '11 18:11

Michael Dodd


2 Answers

This behaviour is described in Android Developers: HttpURLConnection

HttpURLConnection uses the GET method by default. It will use POST if setDoOutput(true) has been called.

What's strange though is that this has not actually been the behaviour until 4.0, so I would imagine it's going to break many existing published apps.

There is more on this at Android 4.0 turns GET into POST.

like image 184
djh Avatar answered Sep 27 '22 17:09

djh


Removing this line worked for me:

connection.setDoOutput(true);

4.0 thinks with this line it should definitely be POST.

like image 40
Fedor Avatar answered Sep 27 '22 18:09

Fedor