ActionResult<IEnumerable<T>> has to return a List<T>

Question

Take the following code using ASP.NET Core 2.1:

[HttpGet("/unresolved")] public async Task<ActionResult<IEnumerable<UnresolvedIdentity>>> GetUnresolvedIdentities() {    var results = await _identities.GetUnresolvedIdentities().ConfigureAwait(false);    return results.ToList(); } 

I would have thought since GetUnresolvedIdentities() returns IEnumerable<UnresolvedIdentity> that I could just return

return await _identities.GetUnresolvedIdentities().ConfigureAwait(false); 

Except I can't, as I get this error:

CS0029 Cannot implicitly convert type 'System.Collections.Generic.IEnumerable<Data.Infrastructure.Models.UnresolvedIdentity>' to 'Microsoft.AspNetCore.Mvc.ActionResult<System.Collections.Generic.IEnumerable<Data.Infrastructure.Models.UnresolvedIdentity>>'

I need the .ToList(), which is annoying as it's 2 lines rather than 1.

Why can't ActionResult<T> figure out that GetUnresolvedIdentities() returns an IEnumerable<> and just return that?

The signature of GetUnresolvedIdentities is:

Task<IEnumerable<UnresolvedIdentity>> GetUnresolvedIdentities(); 

Answer 1

Take this documentation from msdn: https://docs.microsoft.com/en-us/aspnet/core/web-api/action-return-types?view=aspnetcore-2.1#actionresultt-type

C# doesn't support implicit cast operators on interfaces. Consequently, conversion of the interface to a concrete type is necessary to use ActionResult<T>.

Answer 2

You can resolve this in a relatively tidy way by using Ok(...)

[HttpGet] public ActionResult<IEnumerable<MyDTOObject>> Get() => Ok(Repo.GetObjects());  [HttpGet] public async Task<ActionResult<IEnumerable<MyDTOObject>>> GetAsync() => Ok(await Repo.GetObjectsAsync()); 

Which assuming that GetObjects() and GetObjectsAsync() return a IEnumerable<MyDTOObject> and Task<IEnumerable<MyDTOObject>> respectively - allows you to skip .ToList() or .ToListAsync().