Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Why am i getting connection connection closed before server preface received in go?

I am trying to setup a rpc server and a proxy HTTP server over GRPC server on same port using grpc-gateway. Wierdly some times i am getting failed to receive server preface within timeout error randomly. Most of the times it happens on service restarts. It starts working and returns proper response after couple of retries. I am not sure what's happening. Can somebody help me out ? Here is the service startup snippet

func makeHttpServer(conn *grpc.ClientConn) *runtime.ServeMux {
    router := runtime.NewServeMux()

    if err := services.RegisterHealthServiceHandler(context.Background(), router, conn); err != nil {
        log.Logger.Error("Failed to register gateway", zap.Error(err))
    nricher
    if err := services.RegisterConstraintsServiceHandler(context.Background(), router, conn); err != nil {
        log.Logger.Error("Failed to register gateway", zap.Error(err))
    }
    return router
}

func makeGrpcServer(address string) (*grpc.ClientConn, *grpc.Server) {

    grpcServer := grpc.NewServer()
    services.RegisterHealthServiceServer(grpcServer, health.Svc{})
    services.RegisterABCServer(grpcServer, ABC.Svc{})
    conn, err := grpc.DialContext(
        context.Background(),
        address,
        grpc.WithInsecure(),
    )
    if err != nil {
        log.Logger.Error("Failed to dial server", zap.Error(err))
    }

    return conn, grpcServer
}

func httpGrpcRouter(grpcServer *grpc.Server, httpHandler *runtime.ServeMux, listener net.Listener) http.Handler {
    return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        if r.ProtoMajor == 2 {
            grpcServer.Serve(listener)
        } else {
            httpHandler.ServeHTTP(w, r)
        }
    })
}

func Start() error {
    conf := config.Get()
    address := fmt.Sprintf("%s:%d", conf.ServerHost, conf.ServerPort)

    listener, err := net.Listen("tcp", address)
    if err != nil {
        log.Logger.Fatal("failed to listen: %v", zap.Error(err))
    }
    conn, grpcServer := makeGrpcServer(address)
    router := makeHttpServer(conn)

    log.Logger.Info("Starting server on address : " + address)
    err = http.Serve(listener, httpGrpcRouter(grpcServer, router, listener))
    return err
}
like image 205
Kshitij Singh Avatar asked Oct 12 '25 07:10

Kshitij Singh


1 Answers

Try wrapping your router with h2c.NewHandler so the the http.Serve() call looks as follows:

err = http.Serve(listener, h2c.NewHandler(
        httpGrpcRouter(grpcServer, router, listener),
        &http2.Server{})
)
like image 51
jyshin Avatar answered Oct 15 '25 09:10

jyshin