Unused variable in a loop

Question

I need to build a pattern string according to an argument list. If the arguments are "foo", "bar", "data", then pattern should be: "?, ?, ?"

My code is:

List<String> args;
...
for(String s : args) {
  pattern += "?,";
}
pattern = pattern.substring(0, pattern.length()-1);

It works fine, the only concern is, s is not used, it seems the code is a little dirty.

Any improvements for this?

I hope something like:

for(args.size()) {
    ...
}

But apparently there isn't..

Answer 1

You could use the class for loop with conditions:

for (int i = 0, s < args.size(); i++)

In this case, i is being used as a counting variable.

Other than that, there aren't any improvements to be made, although there isn't a need for improvements.