Still resource leak after closing BufferedReader

Question

I'm still learning Java and I need some help understanding why this code is wrong:

BufferedReader infile = new BufferedReader(new FileReader(file));
String regel = infile.readLine();
while (regel != null) {
    // Do something with regel.
    regel = infile.readLine();
}
infile.close();

I really don't see the problem but Eclipse keeps telling there is a resource leak and that infile isn't closed.

(one more detail, this code stands in a try block but I left it away to keep it simple)

Answer 1

Eclipse is complaining because the reference may not be closed (for example, in an Exception); this is where you would use a finally block - perhaps like so

BufferedReader infile = null;
try {
  infile = new BufferedReader(new FileReader(file));
  String regel = infile.readLine();
  while (regel != null) {
    // Do something with regel.
    regel = infile.readLine();
  }
} catch (Exception e) {
  e.printStackTrace(); // Log the exception.
} finally {
  if (infile != null) {
    infile.close(); // close the resource.
  }
}