Rails - before_filter undefined local variable

Question

I have this form where a user input a review. A user must be signed with Facebook to save a review. I use a before_filter to check if the user is signed in or not.

But I get this error: undefined local variable or method signed_in_user' .

The other thing is, how do I logged the user in with facebook and the save its review? Without losing and making the user input the same review again.

Review form:

<%= form_for [@school, Review.new] do |f| %>
 <%= f.text_area :content %>
    <% if current_user %>
      <%= f.submit 'Save my review', :class => "btn" %>
    <% else %>
      <%= f.submit 'Save my review and sign me into facebook', :class => "btn" %>
    <% end %>
<%end %>

ReviewsController

class ReviewsController < ApplicationController
    before_filter :signed_in_user, only: [:create, :destroy]

    def create
        @school = School.find(params[:school_id])
        @review = @school.reviews.new(params[:review])

        @review.user_id = current_user.id

        if @review.save
            redirect_to @review.school, notice: "Review has been created."
        else
            render :new
        end
    end

    def new
        @school = School.find_by_id(params[:school_id])
        @review = Review.new
    end
end

ReviewsHelper

module ReviewsHelper
    def signed_in?
        !current_user.nil?
    end

    def signed_in_user
        unless signed_in?   
            redirect_to "/auth/facebook"
        end
    end
end

I am using omniauth to authenticate users from facebook.

Answer 1

include your ReviewsHelper in controller:

class ReviewsController < ApplicationController
    include ReviewsHelper #or helper :reviews
    before_filter :signed_in_user, only: [:create, :destroy]

    def create
        @school = School.find(params[:school_id])
        @review = @school.reviews.new(params[:review])

        @review.user_id = current_user.id

        if @review.save
            redirect_to @review.school, notice: "Review has been created."
        else
            render :new
        end
    end

    def new
        @school = School.find_by_id(params[:school_id])
        @review = Review.new
    end
end