"Not all code paths return a value" when returning View in MVC

Question

I want to return a view if an object(country) is not null. But I get the error "Not All code paths return a value"

My code looks like this

public ActionResult Show(int id)
{
    if (id != null)
    {
        var CountryId = new SqlParameter("@CountryId", id);
        Country country = MyRepository.Get<Country>("Select * from country where CountryId=@CountryId", CountryId);
        if (country != null)
        {
            return View(country);
        }
    }

}

Answer 1

This happens when you are returning something from within the "if" statement. The compiler thinks, what if the "if" condition is false? That way you are not returning anything even when you have the return type of "ActionResult" defined in the function. So add some default returns in the else statement:

public ActionResult Show(int id)
{

    if (id != null)
    {
        var CountryId = new SqlParameter("@CountryId", id);
        Country country = MyRepository.Get<Country>("Select * from country where CountryId=@CountryId", CountryId);

        if (country != null)
        {
            return View(country);
        }
        else
        {
            return View(something);
        }
    }
    else
    {
        return View(something);
    }
}