iOS Swift CollectionView delegate not getting called

Question

I have conformed the protocols UICollectionViewDelegate, UICollectionViewDelegateFlowLayout, UIScrollViewDelegate to a seperate class named CollectionViewWeekDelegate but the delegate methods such as didSelectItemAt is not getting called.

I'm also setting the delegate to CollectionView in viewDidLoad()

Please find the code below:

Delegate Class

class CollectionViewWeekDelegate: NSObject, UICollectionViewDelegate, UICollectionViewDelegateFlowLayout, UIScrollViewDelegate {

    internal var parent: EarningsViewController?

    func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {

        parent?.weekTabSelectedPosition = indexPath.item

        let indexPathh = IndexPath(item: indexPath.item, section: 0)

        parent?.collectionViewSchedule.scrollToItem(at: indexPathh, at: .right, animated: true)
        parent?.collectionViewWeeks.scrollToItem(at: indexPath, at: .top, animated: true)

        parent?.collectionViewWeeks.reloadData()

    }


    func scrollViewDidEndDecelerating(_ scrollView: UIScrollView) {

        let offsetX = parent?.collectionViewSchedule.contentOffset.x
        let contentWidth = parent?.collectionViewSchedule.bounds.width

        let page = Int(offsetX! / contentWidth!)

        parent?.weekTabSelectedPosition = page



        var earningsText  = "\("grossEarnings".localize()) $\(String(format: "%0.2f", 0.0))"

        if let earnings = parent?.schedules?[page].grossWeekSalary{
            earningsText = "\("grossEarnings".localize()) $\(String(format: "%0.2f", earnings))"


            parent?.buttonGrossEarnings.setTitle(earningsText, for: .normal)

            parent?.collectionViewWeeks.selectItem(at: IndexPath(item: page, section: 0), animated: true, scrollPosition: .centeredHorizontally)}
    }

    func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize {
        if collectionView.tag == 2{
            return CGSize(width: UIScreen.main.bounds.width, height: (parent?.collectionViewSchedule.bounds.height)!)
        }else{
            return CGSize(width: 150, height: 50)
        }
    }
}

viewDidLoad function where the CollectionView delegate is being assigned:

override func viewDidLoad() {
    super.viewDidLoad()
    self.navigationController?.title = "schedule".localize()

    self.navigationItem.leftBarButtonItem = super.getMenuBartItem()

    if let flowLayout = collectionViewWeeks.collectionViewLayout as? UICollectionViewFlowLayout{
        flowLayout.estimatedItemSize = CGSize(width: 150, height: 50)
    }

    if let collectionFlowLayout = collectionViewSchedule.collectionViewLayout as? UICollectionViewFlowLayout{
        collectionFlowLayout.minimumLineSpacing = 0
        collectionFlowLayout.minimumInteritemSpacing = 0

    }

    let weekDelegate = CollectionViewWeekDelegate()
    weekDelegate.parent = self

    collectionViewWeeks.delegate = weekDelegate
    collectionViewSchedule.delegate = self

    collectionViewWeeks.reloadData()
}

Answer 1

Your weekDelegate gets deallocated when viewDidLoad finishes execution - you don't keep a strong reference to it, only the local variable. The only other class holding a reference to it is the UICollectionView itself (in your case collectionViewWeeks), but UICollectionView define its delegate as weak.

Just do this to keep the reference alive:

// create a strong property and use it instead of local variable
fileprivate let weekDelegate = CollectionViewWeekDelegate()

override func viewDidLoad() {
    super.viewDidLoad()
    self.navigationController?.title = "schedule".localize()

    self.navigationItem.leftBarButtonItem = super.getMenuBartItem()

    if let flowLayout = collectionViewWeeks.collectionViewLayout as? UICollectionViewFlowLayout{
        flowLayout.estimatedItemSize = CGSize(width: 150, height: 50)
    }

    if let collectionFlowLayout = collectionViewSchedule.collectionViewLayout as? UICollectionViewFlowLayout{
        collectionFlowLayout.minimumLineSpacing = 0
        collectionFlowLayout.minimumInteritemSpacing = 0

    }

    weekDelegate.parent = self

    collectionViewWeeks.delegate = weekDelegate
    collectionViewSchedule.delegate = self

    collectionViewWeeks.reloadData()
}