IndexOutOfBoundException(Java)

Question

I get an error:

Caused by: java.lang.IndexOutOfBoundsException: Index: 1, Size: 1

from the code below which I think is perfectly fine!! Any guidance will be warmly appreciated

for (int i = 0; i < allVacantRooms.size(); i++) {       
  String allavail=allVacantRooms.get(i).getName();
  System.out.println(allavail);
  for (int j = 0; j < deductableRooms.size(); j++) {
    String alldeduc=deductableRooms.get(j).getReservation()
                        .getReservedRooms().get(j).getRoom();
    System.out.println("allDeduc::"+alldeduc);
  }
}

Answer 1

Seems like the problem is with this line:

String alldeduc = deductableRooms.get(j).getReservation().getReservedRooms().get(j).getRoom();

The get() on ReservedRooms is dangerous!

It seems like you have 2 deductableRooms but only 1 reservedRoom in deductableRoom.get(1).

Maybe you need a third loop over your reservedRooms.
Depends on what you are actually trying to do.
Right now you are printing the ReservedRoom as deductRoom which seems strange to me

Answer 2

You are blindly using the same index on reservationRooms as you are on the reservation they belong to. You should iterate over the room in a separate loop.

Also, your code style is poor; prefer a "for each" loop when you don't need the index (as here).

Also also, the outer loop is not related to the inner loop; they should be separate loops.

Try something like:

for (ReservedRoom room : allVacantRooms) {
    System.out.println(room.getName());
}
for (ReservedRoom room : deductableRooms) {
    for (ReservedRoom reservedRoom : room.getReservation().getReservedRooms()) {
        System.out.println("allDeduc::" + reservedRoom.getName());
    }
}