Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How do you prevent leaks when raising an exception in init?

Here's the situation. Let's say I have a class called MYFoo. Here's it's initializer:

-init
{
  self = [super init];
  if (self)
  {
    // during initialization, something goes wrong and an exception is raised
    [NSException raise ...];
  }
  return self;
}

Now somewhere else I want to use a MYFoo object, so I use a common pattern:

MYFoo *foo = [[[MYFoo alloc] init] autorelease];

But what's going to happen is that, even if there's a try/catch around the 2nd part, a MYFoo object is going to be allocated, the exception will be thrown, the autorelease missed, and the uninitialized MYFoo object will leak.

What should happen here to prevent this leak?

like image 870
stevex Avatar asked Dec 08 '25 06:12

stevex


1 Answers

The Apple Docs say the best practice is not to throw.

Handling Initialization Failure

In general, if there is a problem during an initialization method, you should call [self release] and return nil.

If you need to know what happened, you can init the object and have some kind of internal state that gets checked by the caller to ensure the object is usable.

like image 157
Donald Byrd Avatar answered Dec 09 '25 18:12

Donald Byrd