Disable Winforms button while OnClick code executes in background

Question

I have some code in my "button_click" action. I want to disable the button during this code working.

    private void button1_Click(object sender, RoutedEventArgs e)
    {
        button1.IsEnabled = false;
        // some code (its take about 2-5 sec)
        button1.IsEnabled = true;
    }

But this doesn't work. The button never disables.

Answer 1

You need to run the "some code" part on a background thread:

button1.Enabled = false;
Task.Factory.StartNew(() => {
    // some code (its take about 2-5 sec)
}).ContinueWith(task => {
    button1.Enabled = true;
}, TaskScheduler.FromCurrentSynchronizationContext());

Answer 2

That is because your UI locks up during the entire action.

You should write the task in some sort of background thread.

You can use the BackgroundWorker for that, but better a Task.

BackgroundWorker bgw = new BackgroundWorker();
bgw.DoWork += bgw_DoWork;
bgw.RunWorkerCompleted += bgw_RunWorkerCompleted;

button.Enabled = false;

bgw.RunWorkerAsync();

private void bgw_DoWork(object sender, DoWorkEventArgs e)
{
   // your task
}

private void worker_RunWorkerCompleted(object sender, RunWorkerCompletedEventArgs e)
{
    // update the button
    button.Enabled = true;
}